sipeed-slogic-analyzer: fix channel count and samplerate list#4
Open
heeen wants to merge 1 commit intosipeed:slogic-devfrom
Open
sipeed-slogic-analyzer: fix channel count and samplerate list#4heeen wants to merge 1 commit intosipeed:slogic-devfrom
heeen wants to merge 1 commit intosipeed:slogic-devfrom
Conversation
config_channel_set only allowed increasing the channel count (>), preventing users from lowering it by disabling channels. Change to != so disabling channels properly reduces cur_samplechannel and raises the samplerate limit. Also return the full samplerate table in config_list instead of truncating it based on limit_samplerate. PulseView queries the rate list before channel states are restored, so the truncated list was always stuck at the 16-channel limit. config_set already enforces the per-channel-count limit when a rate is selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_channel_setto allow lowering channel count when disabling channels (was>, now!=)config_listinstead of truncating based onlimit_samplerateProblem
cur_samplechannel, so users couldn't unlock higher sample rates (e.g. 400MHz@8ch, 800MHz@4ch)Fix
config_channel_set: change>to!=so channel count tracks enabled channels in both directionsconfig_list(SR_CONF_SAMPLERATE): return all rates;config_setalready enforces the per-channel-count limit when a rate is selectedTest plan